Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: enable/update tests + fix merge_dicts() #57685

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@mmazur
Copy link
Contributor

commented Jun 11, 2019

SUMMARY

None of the unit tests for kubevirt actually did anything. Fix that.

Also fix the regression in merge_dicts() introduced by this change.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt

@mmazur mmazur changed the title kubevirt: actually run the unit tests [WIP] kubevirt: actually run the unit tests Jun 11, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_fix_tests branch from ea8348c to 53b205c Jun 11, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_fix_tests branch 3 times, most recently from 29f4d33 to 8800c83 Jun 11, 2019

@mmazur mmazur changed the title [WIP] kubevirt: actually run the unit tests [WIP] kubevirt: enable/update tests + fix merge_dicts() Jun 11, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_fix_tests branch from 8800c83 to 14f994f Jun 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_fix_tests branch from 14f994f to a5daece Jun 11, 2019

@mmazur mmazur changed the title [WIP] kubevirt: enable/update tests + fix merge_dicts() kubevirt: enable/update tests + fix merge_dicts() Jun 11, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@machacekondra
Copy link
Contributor

left a comment

+1

@ansibot ansibot added shipit and removed WIP needs_triage labels Jun 11, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_fix_tests branch from a5daece to c52180c Jun 12, 2019

@ansibot ansibot added core_review and removed shipit labels Jun 12, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Just occurred to me I've put the utils unit test in the wrong location and had to repush. Please re+1.

@mmazur mmazur referenced this pull request Jun 12, 2019

Merged

kubevirt: more unit tests #57739

@machacekondra

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

+1

@ansibot ansibot added shipit and removed core_review labels Jun 12, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

test/units/module_utils/test_kubevirt.py
support: core
maintainers:

test/units/modules/cloud/kubevirt/test_kubevirt_vm.py
support: core
maintainers:

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mmazur
shipit_actors_other: []
automerge: automerge community support test failed

click here for bot help

@mkrizek mkrizek merged commit 51add5a into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 127242 status is SUCCESS.
Details

mmazur added a commit to mmazur/ansible that referenced this pull request Jun 13, 2019

kubevirt: enable/update tests + fix merge_dicts() (ansible#57685)
* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code

(cherry picked from commit 51add5a)

abadger added a commit that referenced this pull request Jun 24, 2019

Backport/2.8/57685 (#57794)
* kubevirt: enable/update tests + fix merge_dicts() (#57685)

* Actually run the unit tests and separate them into two files

* Re-add recursion to merge_dicts()

* Update tests to work with current code

(cherry picked from commit 51add5a)

* Changelog fragment

* Replace nested function with dict_transformations.dict_merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.