Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Speeding up Vault Operations" section #57701

Merged
merged 2 commits into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@anis016
Copy link
Contributor

commented Jun 11, 2019

Updated "Speeding up Vault Operations" section on the Vault page, has a phrase that specifies there is still a dependency on pycrypto.

+label: docsite_pr

Fixes #57408

ISSUE TYPE
  • Docs Pull Request
Updated "Speeding up Vault Operations" section
Updated "Speeding up Vault Operations" section on the Vault page, has a phrase that specifies there is still a dependency on pycrypto.

+label: docsite_pr
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@acozine
Copy link
Contributor

left a comment

Thanks @anis016 for picking up this issue and opening a PR to fix it!

My suggestion reverts two of your changes. We want the Ansible documentation to use active voice and address the reader - see https://docs.ansible.com/ansible/latest/dev_guide/style_guide/index.html#stylistic-cheat-sheet for examples and more guidelines on language.

If you'll accept my suggestions, I'll merge your PR.

Show resolved Hide resolved docs/docsite/rst/user_guide/vault.rst Outdated

@ansibot ansibot removed the needs_triage label Jun 11, 2019

Update docs/docsite/rst/user_guide/vault.rst
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@anis016

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@acozine Thank you! I understand. I will remember this from next time.

@samccann samccann merged commit 78f87f2 into ansible:devel Jun 14, 2019

1 check passed

Shippable Run 127169 status is SUCCESS.
Details
@samccann

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Thanks @anis016 for the Ansible documentation fix and for picking up some of the Ansible issues to resolve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.