Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to add Unit TC for Checkpoint network module #57710

Merged
merged 3 commits into from
Jul 18, 2019
Merged

PR to add Unit TC for Checkpoint network module #57710

merged 3 commits into from
Jul 18, 2019

Conversation

justjais
Copy link
Contributor

Signed-off-by: Sumit Jaiswal sjaiswal@redhat.com

SUMMARY

PR to add Unit TC for Checkpoint network module cp_network

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

@justjais
cp_network unit TC
a11270e 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
cp_network unit TC
22e6191 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot
Copy link
Contributor

ansibot commented Jun 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 5 errors:

test/units/modules/network/checkpoint/test_cp_network.py:30:51: E128 continuation line under-indented for visual indent
test/units/modules/network/checkpoint/test_cp_network.py:31:51: E128 continuation line under-indented for visual indent
test/units/modules/network/checkpoint/test_cp_network.py:34:64: E127 continuation line over-indented for visual indent
test/units/modules/network/checkpoint/test_cp_network.py:38:59: E128 continuation line under-indented for visual indent
test/units/modules/network/checkpoint/test_cp_network.py:39:59: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jun 11, 2019

cc @NilashishC @Qalthos @ganeshrn @gdpak @rcarrillocruz @trishnaguha
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jun 11, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jun 13, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 13, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 29, 2019

cc @danielmellado
click here for bot help

@justjais
update
0fc92b9 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 16, 2019
@maxamillion
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 16, 2019
@justjais justjais merged commit b01b1d4 into ansible:devel Jul 18, 2019
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 feature This issue/PR relates to a feature request. networking Network category shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justjais @ansibot @maxamillion @mattclay