Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecs_cluster test suite refactor #57716

Merged
merged 3 commits into from Jun 17, 2019

Conversation

Projects
None yet
5 participants
@willthames
Copy link
Contributor

commented Jun 11, 2019

SUMMARY

Refactor ecs_cluster test suite to newer techniques, and move to ec2_instance from ec2 in the tests to avoid need for boto in test suite.

Reduce the number of testing policies so that setup-iam.yml actually works

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_cluster

willthames added some commits Mar 17, 2019

Combine testing policies
Because of the maximum of 10 policies per group, need to
consolidate testing policies as best we can.
Tidy put-account-setting tasks and add permission
Using `environment` and `command` rather than `shell` avoids the
need for `no_log` and means that people can fix the problem
refactor ecs_cluster test suite
move from runme.sh technique to virtualenv

use ec2_instance rather than ec2 module to
avoid need for boto
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

@s-hertel
Copy link
Contributor

left a comment

Since the pr to overhaul ansible-test code coverage and injector I’ve been unable to run any AWS integration tests that need a virtual environment (without hacking them up first) due to my environment. This test suite is now the exception. Tests are passing and are more readable.

@jillr

jillr approved these changes Jun 17, 2019

Copy link
Contributor

left a comment

passes for me as well, thanks.

@jillr jillr merged commit 924352a into ansible:devel Jun 17, 2019

1 check passed

Shippable Run 127187 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.