Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GCP module: gcp_tpu_node_facts #57730

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@modular-magician
Copy link
Contributor

commented Jun 12, 2019

SUMMARY

New GCP module: gcp_tpu_node_facts

ISSUE TYPE
  • New Module Pull Request
ADDITIONAL INFORMATION
This was generated by [Magic Modules](https://github.com/googlecloudplatform/magic-modules)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_tpu_node_facts.py:0:0: E307 version_added should be '2.9'. Currently 2.8

click here for bot help

@modular-magician modular-magician force-pushed the modular-magician:gcp_tpu_node_facts branch from a460c0d to 3b7de8b Jun 13, 2019

@ansibot ansibot removed the ci_verified label Jun 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

@GwenaelPellenArkeup @Nitaco @bennojoy @dohoangkhiem @erjohnso @GoogleCloudPlatform @rambleraptor @robwagner33 @walbert947

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@rambleraptor

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

shipit

@ansibot ansibot merged commit 1d6d19f into ansible:devel Jun 13, 2019

1 check passed

Shippable Run 127415 status is SUCCESS.
Details
@kustodian

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@modular-magician why did you remove the filtering of warnings in the gcp_utils.py? I guess that is a mistake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.