Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ovsdb module not being idempotent #57735

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@danielmellado
Copy link
Contributor

commented Jun 12, 2019

SUMMARY

Fix openvswitch_db module not being idempotent

openvswitch_db module wasn't treating quoted values in a proper way
when comparing to existing ones.

Fixes #55432

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

openvswitch_db

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@danielmellado, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 12, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now b2195d0

@danielmellado danielmellado force-pushed the danielmellado:ovsdb branch from a6adbea to b2195d0 Jun 12, 2019

@ansibot ansibot added needs_revision and removed core_review labels Jun 12, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 12, 2019

@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 69ebcfd

@danielmellado danielmellado force-pushed the danielmellado:ovsdb branch from b2195d0 to 69ebcfd Jun 12, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jun 12, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 12, 2019

Fix ovsdb module not being idempotent
openvswitch_db was not parsing properly some arguments, which caused
some commands to be executed when they shouldn't. This commit fixesit
and adds unit testing for the usecase.

Closes-Bug: #55432
Closes-bug: #43858
@danielmellado

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Pull-request updated, HEAD is now 05e6dae

@danielmellado danielmellado force-pushed the danielmellado:ovsdb branch from 69ebcfd to 05e6dae Jun 12, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 12, 2019

@ansibot ansibot added the stale_ci label Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.