Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cope with an AWS Auto Scaling Group containing instances not having a launch config any more #57737
We ran into a corner case:
Due to the changes in 2.8.0 to support launch templates, this falls into a hole in get_properties(). Since the instance does not have a "LaunchConfigurationName" or "LaunchTemplate" key, it ends up with neither launch_config_name nor launch_template set, so does not set a value in the dict.
Later on, get_instances_by_launch_template assumes it the dict DOES have a launch_config_name, and you get a failure (see below for example).
It would be good to get this into 2.8.x as a bugfix as well. We found this during a production deploy.
Example error trace: