Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: more unit tests #57739

Merged
merged 4 commits into from Jun 25, 2019

Conversation

Projects
None yet
6 participants
@mmazur
Copy link
Contributor

commented Jun 12, 2019

SUMMARY

We've had a bunch of unit tests written, but we never submitted them upstream. Better late than never.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

For the time being this contains all the commits from #57685. Once that gets merged, I'll rebase this on top of devel.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:16:48: bad-whitespace No space allowed after bracket @pytest.mark.parametrize("_replicas, _changed", ( (1, True),                                                 ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:19:63: bad-whitespace No space allowed before bracket                                                   (5, True), ) )                                                                ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:20:24: bad-whitespace No space allowed after bracket def test_scale_rs_nowait( _replicas, _changed):                         ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:67: bad-whitespace No space allowed around keyword argument assignment     res_inst = openshiftdynamic.ResourceInstance('', dict(metadata = {'name': _name}, spec = {'replicas': 2}))                                                                    ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:91: bad-whitespace No space allowed around keyword argument assignment     res_inst = openshiftdynamic.ResourceInstance('', dict(metadata = {'name': _name}, spec = {'replicas': 2}))                                                                                            ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:68: bad-whitespace No space allowed around keyword argument assignment     KubernetesRawModule.patch_resource.return_value = dict(metadata = {'name': _name}, spec = {'replicas': _replicas}), None                                                                     ^
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:92: bad-whitespace No space allowed around keyword argument assignment     KubernetesRawModule.patch_resource.return_value = dict(metadata = {'name': _name}, spec = {'replicas': _replicas}), None                                                                                             ^

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:16:50: E201 whitespace after '('
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:19:63: E202 whitespace before ')'
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:20:26: E201 whitespace after '('
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:67: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:69: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:91: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:29:93: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:68: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:70: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:92: E251 unexpected spaces around keyword / parameter equals
test/units/modules/cloud/kubevirt/test_kubevirt_rs.py:32:94: E251 unexpected spaces around keyword / parameter equals

click here for bot help

@mmazur mmazur force-pushed the mmazur:kubevirt_more_unit_tests branch from 6b6e789 to 0369dfd Jun 12, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

This closes #52558.

@mmazur mmazur force-pushed the mmazur:kubevirt_more_unit_tests branch from 0369dfd to 3cec3b7 Jun 13, 2019

@samdoran samdoran removed the needs_triage label Jun 13, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_more_unit_tests branch from 3cec3b7 to 6a27ceb Jun 14, 2019

@mmazur mmazur changed the title [WIP] kubevirt: more unit tests kubevirt: more unit tests Jun 14, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

@pkliczewski @machacekondra – please review/+1 and let's try getting batch 1 in

@ansibot ansibot added core_review and removed WIP labels Jun 14, 2019

@machacekondra
Copy link
Contributor

left a comment

+1

@pkliczewski

This comment has been minimized.

Copy link

commented Jun 14, 2019

+1

@ansibot ansibot added the stale_ci label Jun 22, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_more_unit_tests branch from 6a27ceb to a29ada3 Jun 24, 2019

@ansibot ansibot removed the stale_ci label Jun 24, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

I did a rebase just in case. Anybody got any idea who do we get for a reviewer?

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

@willthames nobody (outside the kubevirt modules maintainers) looked at these for the past 2 weeks and these need core approval. What can I do?

@willthames willthames merged commit 0629256 into ansible:devel Jun 25, 2019

1 check passed

Shippable Run 129173 status is SUCCESS.
Details
@willthames

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@mmazur - additional passing tests - what's not to like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.