Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed mounts in podman connector and handle errors #57741

Merged
merged 1 commit into from Jun 15, 2019

Conversation

Projects
None yet
6 participants
@sshnaidm
Copy link
Contributor

commented Jun 12, 2019

Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.

SUMMARY

Fixes #57740
Add support for copying files to/from podman containers without their mount and solve problem with "permission denied".
Alert about failed commands in podman connector.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-podman connection plugin

ADDITIONAL INFORMATION
@@ -0,0 +1,2 @@
bugfixes:
- asnible-podman connection plugin - Fix case when mount of podman container fails and files can't be copied to/from container. Also add error handling in case of failed podman commands. (https://github.com/ansible/ansible/issues/57740)

This comment has been minimized.

Copy link
@ssbarnea

ssbarnea Jun 12, 2019

Contributor

typo

This comment has been minimized.

Copy link
@sshnaidm

sshnaidm Jun 12, 2019

Author Contributor

fixed

@sshnaidm sshnaidm force-pushed the sshnaidm:devel branch 2 times, most recently from 76c4970 to 2daf687 Jun 12, 2019

@ssbarnea
Copy link
Contributor

left a comment

I tested that change with molecule and it works correctly.

@jamescassell

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Looks like a good fix, but I haven't tested.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@sshnaidm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

I prepared a test script for your convenience to test this PR on fedora/centos hosts: https://gist.github.com/sshnaidm/53841acabec3fcf229f6864ea040dadd
I tested it on centos7, fedora28, fedora29, fedora30. Problems with mount appear in f29 and f30, and patch solved them.

@TomasTomecek

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I close my PR which solves the same issue. #57584

@TomasTomecek
Copy link
Contributor

left a comment

One nit, otherwise LGTM

Show resolved Hide resolved lib/ansible/plugins/connection/podman.py

@ansibot ansibot removed the needs_triage label Jun 13, 2019

@sshnaidm sshnaidm force-pushed the sshnaidm:devel branch from 2daf687 to 1a36e21 Jun 13, 2019

@TomasTomecek
Copy link
Contributor

left a comment

lgtm, nicely done!

Fix failed mounts in podman connector and handle errors
Like it's described in issue #57740 ansible podman fails to run
because of failed mount of rootless container.

@sshnaidm sshnaidm force-pushed the sshnaidm:devel branch from 1a36e21 to e8af16c Jun 15, 2019

@willthames

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

rebuild_merge

@ansibot ansibot added shipit and removed community_review labels Jun 15, 2019

@ansibot ansibot merged commit 7910361 into ansible:devel Jun 15, 2019

1 check passed

Shippable Run 127771 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.