Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set ovirt disk active default (#57464) #57748

Open
wants to merge 3 commits into
base: stable-2.8
from

Conversation

Projects
None yet
3 participants
@mnecas
Copy link
Contributor

commented Jun 12, 2019

Backport of #57464

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

set ovirt disk active default (#57464)
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_disk.py:689:15: undefined-variable Undefined variable 'vm_service'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@@ -684,6 +685,9 @@ def main():
ret = None
# First take care of creating the VM, if needed:
if state in ('present', 'detached', 'attached'):
# Always activate disk when its being created

This comment has been minimized.

Copy link
@mwperina

mwperina Jun 13, 2019

Contributor

You need to define vm_service:

vm_service = get_vm_service(connection, module)

This comment has been minimized.

Copy link
@mnecas

mnecas Jun 13, 2019

Author Contributor

Yeah sorry it was defined already in devel i have not noticed that it wasnt in stable28

@ansibot ansibot removed the needs_triage label Jun 13, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_disk.py:688:25: undefined-variable Undefined variable 'get_vm_service'

click here for bot help

@mwperina
Copy link
Contributor

left a comment

shipit

@ansibot ansibot added shipit and removed community_review labels Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.