Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Creating two IPs in single run of netbox_ip_address (#56550) #57760

Merged
merged 1 commit into from Jun 15, 2019

Conversation

Projects
None yet
4 participants
@FragmentedPacket
Copy link
Contributor

commented Jun 12, 2019

  • Found bug, fixed by moving the serialization of objects out of try while creating objects

  • Added changelog to document fix

(cherry picked from commit d07d394)

SUMMARY

This is to backport the changes from PR #56550

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/net_tools/netbox/netbox_utils.py

Bugfix: Creating two IPs in single run of netbox_ip_address (#56550)
* Found bug, fixed by moving the serialization of objects out of try while creating objects

* Added changelog to document fix

(cherry picked from commit d07d394)
@FragmentedPacket

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@s-hertel Hey Sloane, sorry to bug you here, but looks like it's getting an error fetching the PR for tests. Is this something I can fix or that I'm doing wrong?

@s-hertel

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

@FragmentedPacket np, I restarted those

@abadger abadger merged commit 395b722 into ansible:stable-2.8 Jun 15, 2019

1 check passed

Shippable Run 127326 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

Merged for the 2.8.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.