Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_defrag: not running on all drives using /C #57902

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@ShachafGoldstein
Copy link
Contributor

commented Jun 16, 2019

SUMMARY

Fixes: #48660

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_defrag.ps1

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@jborean93 @nitzmahone - Please review when you have the time

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

Code change looks good to me.

@ansibot ansibot added the stale_ci label Jun 25, 2019

@specator

This comment has been minimized.

Copy link

commented Jun 27, 2019

It strange because on WS2016 (1607) it works fine, but on WS2019 (1809 and 1903) this returns nothing.

@specator

This comment has been minimized.

Copy link

commented Jun 27, 2019

I think that problem with [String]::Join(' ', ... ) because just (Get-CimInstance -Class Win32_Volume -Filter "(drivetype=3 OR drivetype=2)" -Property DriveLetter).DriveLetter) returns correct array with DriveLetters.

@specator

This comment has been minimized.

Copy link

commented Jun 27, 2019

Also I had checked that your script do not include partitions mapped with mountpoints (link). E.g. when I can mount a partition to c:\mounted drives\Vol1

@ansibot ansibot added the owner_pr label Jun 27, 2019

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Changed to fix mounted path issue, regarding the WS2019, can you tell me what .net and Powershell versions you have on the machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.