Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to fix minor issues with Checkpoint module #58049

Merged
merged 2 commits into from Jul 16, 2019

Conversation

Projects
None yet
3 participants
@justjais
Copy link
Contributor

commented Jun 19, 2019

Signed-off-by: Sumit Jaiswal sjaiswal@redhat.com

SUMMARY

PR to fix minor issues with Checkpoint module, making state default option to present and resolving error scenario.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

minor checkpoint module fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

@justjais justjais requested a review from maxamillion Jun 19, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/cp_network.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)

click here for bot help

state default value set
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@maxamillion

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

rebuild_merge

@ansibot ansibot merged commit 0bde145 into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 132389 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.