Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new module ce lacp to manage Eth-Trunk interfaces mode #58077

Open
wants to merge 16 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@xuxiaowei0512
Copy link
Contributor

commented Jun 19, 2019

SUMMARY

Specifies the working mode of an Eth-Trunk interface.
Specifies lacp preempt enable of Eth-Trunk lacp.
And other lcap options.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_lacp.py

ADDITIONAL INFORMATION

example:

tasks:

  • name: Ensure Eth-Trunk100 is created, add two members, and set to mode lacp-static
    ce_eth_trunk:
    trunk_id: 100
    members: ['10GE1/0/24','10GE1/0/25']
    mode: 'lacp-static'

  • device will show configuration:

interface Eth-Trunk 100
mode lacp-static
interface 10GE1/0/24 10GE1/0/25


@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@xuxiaowei0512 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_lacp.py:152:161: E501 line too long (171 > 160 characters)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_lacp.py:152:161: E501 line too long (171 > 160 characters)

click here for bot help

@ansibot ansibot added shipit and removed needs_triage labels Jul 6, 2019

@Andersson007

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@xuxiaowei0512 what about integration tests for this module?

Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated
Show resolved Hide resolved lib/ansible/modules/network/cloudengine/ce_lacp.py Outdated

@ansibot ansibot added needs_revision and removed shipit labels Jul 10, 2019

xuxiaowei0512 added some commits Jul 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_lacp.py:152:36: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/cloudengine/ce_lacp.py:153:27: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 3 errors:

lib/ansible/modules/network/cloudengine/ce_lacp.py:142:5: key-duplicates EXAMPLES: duplication of key "ce_lacp" in mapping
lib/ansible/modules/network/cloudengine/ce_lacp.py:146:5: key-duplicates EXAMPLES: duplication of key "ce_lacp" in mapping
lib/ansible/modules/network/cloudengine/ce_lacp.py:153:27: error EXAMPLES: syntax error: expected <block end>, but found ','

click here for bot help

@ansibot ansibot added the ci_verified label Jul 10, 2019

xuxiaowei0512 added some commits Jul 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Components

lib/ansible/modules/network/cloudengine/ce_lacp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/units/modules/network/cloudengine/init.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/ce_module.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_00.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_01.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_10.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_11.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/test_ce_lacp.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

Metadata

waiting_on: xuxiaowei0512
changes_requested_by: Andersson007
needs_info: False
needs_revision: True
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): False
community_shipits (namespace maintainers): False
ansible_shipits (core team members): False
shipit_actors (maintainer or core team member): None
shipit_actors_other:
automerge: automerge shipit test failed

click here for bot help

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

ready_for_review

@ansibot ansibot added core_review and removed needs_revision labels Jul 11, 2019

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Components

lib/ansible/modules/network/cloudengine/ce_lacp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/units/modules/network/cloudengine/init.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/ce_module.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_00.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_01.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_10.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_11.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/test_ce_lacp.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): xuxiaowei0512
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@hwDCN

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

shipit

@ansibot ansibot added shipit and removed core_review labels Jul 11, 2019

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Components

lib/ansible/modules/network/cloudengine/ce_lacp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/units/modules/network/cloudengine/init.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/ce_module.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_00.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_01.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_10.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_11.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/test_ce_lacp.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): hwDCN xuxiaowei0512
shipit_actors_other: []
automerge: automerge community support test failed

click here for bot help

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Components

lib/ansible/modules/network/cloudengine/ce_lacp.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward hwDCN niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

test/units/modules/network/cloudengine/init.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/ce_module.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_00.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_01.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_10.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/fixtures/ce_lacp/ce_lacp_11.txt
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

test/units/modules/network/cloudengine/test_ce_lacp.py
support: core
maintainers: NilashishC Qalthos danielmellado ganeshrn justjais rcarrillocruz trishnaguha

Metadata

waiting_on: ansible
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): hwDCN xuxiaowei0512
shipit_actors_other: []
automerge: automerge community support test failed

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.