Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aci_extepg.py and aci_extsubnet.py #58079

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@sig9org
Copy link

commented Jun 19, 2019

SUMMARY

Implementation of ACI ExtEpg module.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aci_extepg

ADDITIONAL INFORMATION

Tested on 4.1(2g).

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test pylint [explain] failed with 6 errors:

lib/ansible/modules/network/aci/aci_extepg.py:239:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_extepg.py:279:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_extepg.py:281:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:247:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:294:0: trailing-whitespace Trailing whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:296:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/modules/network/aci/aci_extepg.py:239:1: W293 blank line contains whitespace
lib/ansible/modules/network/aci/aci_extepg.py:279:1: W293 blank line contains whitespace
lib/ansible/modules/network/aci/aci_extepg.py:281:1: W293 blank line contains whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:59:161: E501 line too long (161 > 160 characters)
lib/ansible/modules/network/aci/aci_extsubnet.py:247:1: W293 blank line contains whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:294:1: W293 blank line contains whitespace
lib/ansible/modules/network/aci/aci_extsubnet.py:296:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 8 errors:

lib/ansible/modules/network/aci/aci_extepg.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E322 Argument 'ip, address' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E323 Argument 'address' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E323 Argument 'ip' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E326 Argument 'scope' in argument_spec defines choices as ([['export-rtctrl'], ['import-security'], ['shared-rtctrl'], ['shared-security']]) but documentation defines choices as ([])
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E336 Argument 'ip, address' is not a valid python identifier
lib/ansible/modules/network/aci/aci_extsubnet.py:0:0: E337 Argument 'scope' in argument_spec defines type as 'list' but documentation doesn't define type

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@sig9org this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@sig9org, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

sig9org added some commits Jun 19, 2019

@rsmeyers

This comment has been minimized.

Copy link

commented Jun 19, 2019

Please rename to
aci_l3out_extepg

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/modules/list_of_all_modules.rst:39:0: undefined-label: undefined label: aci_extepg_module (if the link has no caption the label must precede a section header)
docs/docsite/rst/modules/list_of_network_modules.rst:56:0: undefined-label: undefined label: aci_extepg_module (if the link has no caption the label must precede a section header)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/aci/aci_extepg.py:0:0: E305 DOCUMENTATION.module: not a valid value for dictionary value @ data['module']. Got 'aci_l3out_extepg'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

@brunocalogero @devarshishah3 @fadallar @jmcgill298 @koladiya @mtorelli @rost-d @rsmeyers @schunduri @sgerhart @smnmtzgr @tknipper11

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@sig9org

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

Hi,

Do you need anything to merge?

Regards,

@ansibot ansibot added the stale_ci label Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.