Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout to gcp_dns_resource_record_set #58125

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@thexder1
Copy link

commented Jun 20, 2019

SUMMARY

Added timeout value to gcp_dns_resource_record_set
We experienced difficulties in updating google cloud DNS and this appeared to stem from session timing out before retries would happen and it would take a long time to error out. This appears to be effective in avoiding those errors.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcp_dns_resource_record_set

ADDITIONAL INFORMATION

We were updating potentially 70+ records at a time on google cloud dns. Generally after about 10 Ansible would seem to hang for 5+ minutes before finally throwing an error saying it lost connection.

Adding a timeout gives the underlying library a chance to retry the update as well as making retries in Ansible effective. What we have seen is the errors completely disappeared when setting the timeout.


Added timeout to gcp_dns_resource_record_set which when used appears to
be effective in avoiding lost connection errors.
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py:0:0: E322 Argument 'timeout' is listed in the argument_spec, but not documented in the module documentation

click here for bot help

@ansibot ansibot removed the needs_triage label Jun 21, 2019

@ansibot ansibot added the stale_ci label Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.