Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet: FortiSIEM Module_Utils and First Module #58149

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@ftntcorecse
Copy link
Contributor

commented Jun 21, 2019

SUMMARY

First commit for FortiSIEM module_utils and a module. Once this approved, 9 more modules await PR.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

module_utils/network/fortisiem/fortisiem.py
module_utils/network/fortisiem/common.py
fsm_cmdb_devices.py

ADDITIONAL INFORMATION

fsm_cmdb_devices.py will query FortiSIEM for devices in its CMDB.


@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ftntcorecse, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/module_utils/network/fortisiem/common.py:692:8: E114 indentation is not a multiple of four (comment)
lib/ansible/module_utils/network/fortisiem/fortisiem.py:542:53: E126 continuation line over-indented for hanging indent
lib/ansible/module_utils/network/fortisiem/fortisiem.py:670:27: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/fortisiem.py:672:25: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 14 errors:

lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E322 Argument 'export_csv_to_file_path' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E324 Argument 'export_json_to_file_path' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E324 Argument 'export_xml_to_file_path' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'export_csv_to_file_path' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'export_json_to_file_path' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'export_json_to_screen' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'export_xml_to_file_path' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'host' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'ignore_ssl_errors' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'ip' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'ip_range' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E337 Argument 'mode' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E338 Argument 'password' in argument_spec uses default type ('str') but documentation doesn't define type
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E338 Argument 'username' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

The test ansible-test sanity --test pep8 [explain] failed with 11 errors:

lib/ansible/module_utils/network/fortisiem/common.py:66:5: E122 continuation line missing indentation or outdented
lib/ansible/module_utils/network/fortisiem/common.py:69:5: E122 continuation line missing indentation or outdented
lib/ansible/module_utils/network/fortisiem/common.py:75:5: E122 continuation line missing indentation or outdented
lib/ansible/module_utils/network/fortisiem/common.py:465:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/common.py:466:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/common.py:467:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/common.py:468:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/common.py:469:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/common.py:487:29: E127 continuation line over-indented for visual indent
lib/ansible/module_utils/network/fortisiem/fortisiem.py:542:53: E126 continuation line over-indented for hanging indent
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:89:1: W293 blank line contains whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E324 Argument 'export_csv_to_file_path' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E324 Argument 'export_json_to_file_path' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/network/fortisiem/fsm_cmdb_devices.py:0:0: E324 Argument 'export_xml_to_file_path' in argument_spec defines default as (None) but documentation defines default as ('None')

click here for bot help

lweighall added some commits Jun 21, 2019

@ansibot ansibot removed the ci_verified label Jun 21, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jun 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2019

@ansibot ansibot added the stale_ci label Jun 29, 2019

@ftntcorecse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@NilashishC Hello! We've been stale on these PR's for almost three weeks. You were kind enough to merge our previous rounds. Can you please take a look at this one for us? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.