Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fortinet: fmgr_fwpol_ipv4 update/behavioral option fix #58154

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@ftntcorecse
Copy link
Contributor

commented Jun 21, 2019

Bug fix for fmgr_fwpol_ipv4 according to #58019

Module now allows user to decide to skip or fail playbook execution upon discovery of a failed object dependency.

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

fmgr_fwpol_ipv4.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ftntcorecse, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/fortimanager/fmgr_fwpol_ipv4.py:1036:98: E127 continuation line over-indented for visual indent

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/fortimanager/fmgr_fwpol_ipv4.py:0:0: E309 version_added for new option (fail_on_missing_dependency) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot

This comment has been minimized.

@ftntcorecse

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Shipit

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@ansibot ansibot added the stale_ci label Jul 5, 2019

@ftntcorecse

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@NilashishC Hello! We've been stale on these PR's for almost three weeks. You were kind enough to merge our previous rounds. Can you please take a look at this one for us? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.