Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: new module vmware_guest_extra_configs #58276

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@Akasurde
Copy link
Member

commented Jun 24, 2019

SUMMARY

Manage extra / advanced configuration related to VM

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

lib/ansible/module_utils/vmware.py
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 4 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:171:43: undefined-variable Undefined variable 'VmomiSupport'
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:173:43: undefined-variable Undefined variable 'VmomiSupport'
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:184:39: undefined-variable Undefined variable 'VmomiSupport'
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:186:39: undefined-variable Undefined variable 'VmomiSupport'

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'configs' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'datacenter' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'folder' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'name' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/vmware/vmware_guest_extra_configs.py:0:0: E337 Argument 'uuid' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@ansibot

This comment has been minimized.

VMware: new module vmware_guest_extra_configs
Manage extra / advanced configuration related to VM

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

@Akasurde Akasurde force-pushed the Akasurde:vmware_guest_extra_config_manager branch from 0bcebe7 to 61de357 Jun 25, 2019

@ansibot ansibot removed the ci_verified label Jun 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@GBrawl @MikeKlebolt @Tomorrow9 @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @davidmhewitt @garbled1 @gyorgypeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @nafpliot-ibm @nerzhul @oboukili @pgbidkar @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.