Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add size option to the ping modules #58344

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@Tachashi
Copy link

commented Jun 25, 2019

SUMMARY

Add size option to the ios_ping and nxos_ping modules.
This option specify the datagram size of icmp packets.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ios_ping and nxos_ping

ADDITIONAL INFORMATION

@Tachashi Tachashi changed the title add size option add size option to the ping modules Jun 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@Tachashi, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/ios/ios_ping.py:0:0: E309 version_added for new option (size) should be '2.9'. Currently StrictVersion ('0.0')
lib/ansible/modules/network/nxos/nxos_ping.py:0:0: E309 version_added for new option (size) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@pabelanger
Copy link
Contributor

left a comment

Thanks, I'd like to see us also add integration testing to:
https://github.com/ansible/ansible/blob/devel/test/integration/targets/ios_ping/tests/cli/ping.yaml

We currently don't have nxos_ping, but it would be super if you were to also add that.

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 25, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision and removed core_review labels Jun 25, 2019

@ansibot ansibot added the test label Jun 25, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jun 25, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

Thanks! The ansible-test-network-integration-ios-python36 failure, is unrelated it seems. I'll be looking into it more, as it looks like we may have a race condition in our testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.