Skip to content

[WIP] Add initial implementation of RFC 7464 JSON stream#58408

Draft
webknjaz wants to merge 9 commits intoansible:develfrom
webknjaz:feature/rfc7464-json-records-streaming
Draft

[WIP] Add initial implementation of RFC 7464 JSON stream#58408
webknjaz wants to merge 9 commits intoansible:develfrom
webknjaz:feature/rfc7464-json-records-streaming

Conversation

@webknjaz
Copy link
Copy Markdown
Member

@webknjaz webknjaz commented Jun 26, 2019

SUMMARY

Implement JSON streaming according to RFC 7464 which should allow ignoring any garbage in between JSON records in a robust fashion.

Ref: https://tools.ietf.org/html/rfc7464
Ref: https://en.wikipedia.org/wiki/JSON_streaming#Record_separator-delimited_JSON

Related: #13620

Fixes #54949 (potentially)

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

N/A

ADDITIONAL INFORMATION

RFC 7464 describes a way of streaming a series of JSON documents wrapped with RS and LF markers.

@webknjaz webknjaz self-assigned this Jun 26, 2019
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 26, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jun 26, 2019
@webknjaz webknjaz force-pushed the feature/rfc7464-json-records-streaming branch from e39a529 to f87efbf Compare July 2, 2019 10:28
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 2, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2019
@webknjaz webknjaz force-pushed the feature/rfc7464-json-records-streaming branch from 4a999f5 to 75b2269 Compare July 27, 2019 14:47
@ansibot ansibot added module This issue/PR relates to a module. utilities Utilities category and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 27, 2019
@ansibot

This comment has been minimized.

Sign in to view
@webknjaz webknjaz force-pushed the feature/rfc7464-json-records-streaming branch from 75b2269 to b23a179 Compare July 27, 2019 16:17
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@ansibot

This comment has been minimized.

Sign in to view
@webknjaz webknjaz force-pushed the feature/rfc7464-json-records-streaming branch from 7f3e3aa to fb88747 Compare July 30, 2019 14:16
@ansibot

This comment has been minimized.

Sign in to view
@webknjaz webknjaz force-pushed the feature/rfc7464-json-records-streaming branch from fb88747 to dacf7f6 Compare August 1, 2019 16:50
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the cloud label Aug 1, 2019
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 8, 2020
@webknjaz webknjaz mentioned this pull request Aug 7, 2023
Open
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot

This comment was marked as resolved.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@webknjaz webknjaz

Labels

affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. docker feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category packaging Packaging category remote_management Working Group: https://docs.ansible.com/ansible/latest/community/communication.html stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_pr This PR has not been pushed to for more than one year. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. utilities Utilities category windows Windows community WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dnf: successful etckeeper commit causes successful package install to fail

6 participants

@webknjaz @ansibot @shahnewazrifat @sivel @Akasurde @mkrizek