Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop ignoring merge hash behaviour in inventory #58460

Merged
merged 5 commits into from Jul 17, 2019

Conversation

Projects
None yet
5 participants
@bcoca
Copy link
Member

commented Jun 27, 2019

fixes #58120

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

inventory

bcoca added some commits Jun 28, 2019

@bcoca bcoca changed the title [WIP] stop ignoring merge hash behaviour in inventory Stop ignoring merge hash behaviour in inventory Jun 28, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

@acozine
Copy link
Contributor

left a comment

This seems like a victory for consistency in the code. I made two suggestions on the docs - generally looks good.

Show resolved Hide resolved changelogs/fragments/hash_behaviour_inventory.yml Outdated
Show resolved Hide resolved docs/docsite/rst/porting_guides/porting_guide_2.9.rst Outdated

bcoca and others added some commits Jun 28, 2019

Update changelogs/fragments/hash_behaviour_inventory.yml
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
@acozine
Copy link
Contributor

left a comment

Looks good, thanks for accepting the docs suggestions @bcoca.

@bcoca bcoca merged commit 48d4d6e into ansible:devel Jul 17, 2019

1 check passed

Shippable Run 131787 status is SUCCESS.
Details

@bcoca bcoca deleted the bcoca:allow_hash_merge_inventory branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.