Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_rm_virtualmachine_facts must return results in ansible_facts #58462

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@ronansalmon
Copy link

commented Jun 27, 2019

SUMMARY

facts are not usable. This patch fixes azure_rm_virtualmachine_facts.
facts will be available through azure_virtualmachine.

this reproduce the behaviour of other functions like azure_rm_*_facts

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualmachine_facts.py

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@ronansalmon, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

@ronansalmon Thanks for your contribution! @zikalino @yungezz Please review this one when you are free.

@@ -65,7 +65,7 @@
'''

RETURN = '''
vms:
azure_virtualmachine:

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 28, 2019

Contributor

You should never change the return values of an existing module. This will break backwards compatibility.

@@ -254,7 +254,7 @@ def __init__(self):

self.results = dict(
changed=False,
vms=[]
ansible_facts=dict(azure_virtualmachine=[])

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 28, 2019

Contributor

No cloud modules should return ansible_facts. All cloud _facts modules should be _info modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.