Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to support fortios firmware upgrade with local firmware file #58476

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@fortinetps
Copy link

commented Jun 27, 2019

SUMMARY

Fortinet is adding this firmware upgrade module to support firmware upgrade on FortiOS and FortiGate products with local firmware file.
Firmware upgrade module is one of the high demand modules from our end users.
This module follows the same format as other already approved FortiOS modules in Ansible 2.8 release.
I've tested this module thoroughly in my lab with real FortiGate VM and FortiGate appliance.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

fortios_system_firmware_upgrade

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:117:11: W291 trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 9 errors:

lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E307 version_added should be '2.9'. Currently '2.8'
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E323 Argument 'state' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E337 Argument 'host' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E337 Argument 'password' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E337 Argument 'system_firmware' in argument_spec defines type as 'dict' but documentation doesn't define type
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E337 Argument 'username' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:0:0: E337 Argument 'vdom' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:20:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:20:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

@fortinetps, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:207:1: E302 expected 2 blank lines, found 1

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:20:0: E106 Import found before documentation variables. All imports must appear below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.
lib/ansible/modules/network/fortios/fortios_system_firmware_upgrade.py:20:0: E107 Imports should be directly below DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA.

click here for bot help

@ansibot ansibot added the ci_verified label Jul 12, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@bjolivot @mamunozgonzalez @thomnico

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.