Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX azure_rm_subnet_facts: when trying to get all subnets, the wro… #58491

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@ronansalmon
Copy link

commented Jun 28, 2019

SUMMARY
  • fix the following error :
    An exception occurred during task execution. To see the full traceback, use -vvv. The error was: TypeError: get() takes at least 4 arguments (3 given)

  • fix ansible_facts variable

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_subnet_facts.py

Ronan SALMON
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

@ronansalmon, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

'''

RETURN = '''
subnets:
azure_subnets:

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 28, 2019

Contributor

Same here: never change return values.

)
# store the results of the module operation
self.results = dict(
changed=False
changed=False,
ansible_facts=dict(azure_subnets=[])

This comment has been minimized.

Copy link
@felixfontein

felixfontein Jun 28, 2019

Contributor

Also, don't return ansible_facts from cloud modules.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_subnet_facts.py:197:56: E128 continuation line under-indented for visual indent

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@ronansalmon Thank for your contribution, Please help resolve the shippable fail when you're free! Thank you very much!

@ronansalmon

This comment has been minimized.

Copy link
Author

commented Jul 1, 2019

Will send a patch when i'll get back in 3 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.