Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the none idempotency for multiple nics #58509

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@AndyO91
Copy link

commented Jun 28, 2019

SUMMARY

When a server is created with multiple nics which holds security groups, module was applying default SG to the server & remove SG on the nics.

This fixe propose to mutually exclude SG & nics: We can apply SG on nics OR on server directly in order to keep idempotency.

Openstak python library expected no security groups send when this field is not filled and the module was filling the security_groups field with an array which contains the default SG. So during the exchange, library was executing the array by default so it removed all security groups on nics. I modified it for None as a default value.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_server module

ADDITIONAL INFORMATION
Fixed the non idempotency for multiple nics
##### SUMMARY
When a server is created with multiple nics which holds security groups, module was applying default SG to the server & remove SG on the nics.

This fixed propose to muttually exclude SG & nics: We can apply SG on nics OR on server directly in order to keep idempotency.

##### ISSUE TYPE
- Bug fixe
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:684:13: bad-whitespace No space allowed before :         else :              ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/openstack/os_server.py:684:13: E203 whitespace before ':'

click here for bot help

@ansibot

This comment has been minimized.

@opendev-zuul

This comment has been minimized.

Copy link

commented Jun 28, 2019

Build succeeded (third-party-check pipeline).

@AndyO91 AndyO91 changed the title Fixed the non idempotency for multiple nics Fixed the none idempotency for multiple nics Jun 29, 2019

@opendev-zuul

This comment has been minimized.

Copy link

commented Jun 29, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci label Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.