Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

na_ontap_quota was not using vserver #58594

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@carchi8py
Copy link
Contributor

commented Jul 1, 2019

SUMMARY

na_ontap_quota was not using verserver

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_quotas
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@@ -326,7 +327,7 @@ def apply(self):
elif cd_action == 'delete':
self.quota_entry_delete()
elif modify_quota is not None:
for key in list(modify_quota):
for key in modify_quota:

This comment has been minimized.

Copy link
@lonico

lonico Jul 2, 2019

Contributor

This line should not be modified

Though it would have been cleaner to create a new dictionary, since it is only used locally to call self.quota_entry_modify

@ansibot ansibot added the stale_ci label Jul 10, 2019

@lonico

lonico approved these changes Jul 11, 2019

Copy link
Contributor

left a comment

shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.