Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.6] Skip tests with unsatisfied deps (#55853) #58613

Open
wants to merge 2 commits into
base: stable-2.6
from

Conversation

Projects
None yet
3 participants
@abadger
Copy link
Member

commented Jul 2, 2019

  • Skip gitlab tests if dependencies aren't met

  • Skip certain unittests if passlib is not installed

  • Fix tests with deps on paramiko to skip if paramiko is not installed

  • Use pytest to skip for cloudstack

If either on Python-2.6 or the cs library is not installed we cannot run
this test so skip it.
(cherry picked from commit 8acf71f)

Co-authored-by: Toshio Kuratomi a.badger@gmail.com.
(cherry picked from commit 7d4e9b2)

Co-authored-by: Toshio Kuratomi a.badger@gmail.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

The backport is heavily modified to apply cleanly to the 2.6 unittests

[stable-2.6] [stable-2.7] Skip tests with unsatisfied deps (#55853)
* Skip gitlab tests if dependencies aren't met

* Skip certain unittests if passlib is not installed

* Fix tests with deps on paramiko to skip if paramiko is not installed

* Use pytest to skip for cloudstack

If either on Python-2.6 or the cs library is not installed we cannot run
this test so skip it.
(cherry picked from commit 8acf71f)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>.
(cherry picked from commit 7d4e9b2)

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

test/units/plugins/lookup/test_password.py:435:49: undefined-variable Undefined variable 'to_bytes'
test/units/plugins/lookup/test_password.py:493:49: undefined-variable Undefined variable 'to_bytes'

click here for bot help

@ansibot ansibot removed the ci_verified label Jul 2, 2019

@ansibot ansibot added the stale_ci label Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.