Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add win_initialize_disk module #58617

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@branic
Copy link

commented Jul 2, 2019

SUMMARY

This module allows for initializing disks on a Windows system.

When needing to automate the creation of disks on a server to become usable after the disk is presented to the server it must be initialized before it can be partitioned and then formatted. There are existing modules to partition and format disks, this module adds the missing capability to initialize them.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_initialize_disk

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/win_initialize_disk/aliases:0:0: missing alias `shippable/windows/group[1-6]` or `unsupported`

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:82:4: W292 no newline at end of file

The test ansible-test sanity --test validate-modules [explain] failed with 6 errors:

lib/ansible/modules/windows/win_initialize_disk.ps1:0:0: E322 Argument 'bring_online' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/windows/win_initialize_disk.ps1:0:0: E323 Argument 'online' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/windows/win_initialize_disk.ps1:0:0: E324 Argument 'bring_online' in argument_spec defines default as (True) but documentation defines default as (False)
lib/ansible/modules/windows/win_initialize_disk.ps1:0:0: E337 Argument 'bring_online' in argument_spec defines type as 'bool' but documentation doesn't define type
lib/ansible/modules/windows/win_initialize_disk.py:0:0: E305 DOCUMENTATION.version_added: required key not provided @ data['version_added']. Got None
lib/ansible/modules/windows/win_initialize_disk.py:0:0: E307 version_added should be '2.9'. Currently None

click here for bot help

@ansibot

This comment has been minimized.

@branic branic force-pushed the branic:win_initialize_disk_module branch from b33ecb7 to 9fccb12 Jul 2, 2019

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

haven't gone over the whole code but would be great IMO to have path and Id options too and not only number as selectors

@ansibot

This comment has been minimized.

@branic

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

@ShachafGoldstein That's a good idea. I'll add path and id as options.

branic added some commits Jul 2, 2019

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

If you could also add check mode and idempotency, that would be amazing

@branic

This comment has been minimized.

Copy link
Author

commented Jul 2, 2019

If you could also add check mode and idempotency, that would be amazing

@ShachafGoldstein it already supports check mode and idempotency. Is there somewhere that you see where check mode isn't supported or is not idempotent? (or was this in reference to the request to support lists?)

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Nvm my bad

@ansibot ansibot added the stale_ci label Jul 11, 2019

@branic

This comment has been minimized.

Copy link
Author

commented Jul 11, 2019

@jborean93 @ShachafGoldstein any additional comments or thoughts on getting this merged?

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

None from me

@branic branic closed this Jul 14, 2019

@branic branic reopened this Jul 14, 2019

@ansibot ansibot removed the stale_ci label Jul 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:0:0: missing: __metaclass__ = type

click here for bot help

@ansibot ansibot removed the ci_verified label Jul 16, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:76:0: anomalous-backslash-in-string Anomalous backslash in string: '\s'. String constant might be missing an r prefix.

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Output on stderr from ansible-doc is considered an error.

Command "ansible-doc -t module win_initialize_disk" returned exit status 0.
>>> Standard Error
<unknown>:76: SyntaxWarning: invalid escape sequence \s

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:76:0: SyntaxWarning: invalid escape sequence \s

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:100:19: W605 invalid escape sequence '\s'

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:95:1: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_initialize_disk.py:95:1: error EXAMPLES: syntax error: expected <block end>, but found '?'

click here for bot help

@branic branic force-pushed the branic:win_initialize_disk_module branch from 6f512e9 to a90bb14 Jul 16, 2019

@branic branic closed this Jul 16, 2019

@branic branic reopened this Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.