Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Add support for storagePod #58627

Merged
merged 2 commits into from Jul 16, 2019

Conversation

Projects
None yet
4 participants
@Akasurde
Copy link
Member

commented Jul 2, 2019

SUMMARY

Now, user can be specify datastore cluster for deploying OVF

Fixes: #57849 #51826

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/vmware.py
lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py:0:0: E325 Argument 'networks' in argument_spec defines type as 'dict' but documentation defines type as 'str'
lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py:0:0: E325 Argument 'ovf' in argument_spec defines type as <function path_exists at 0x7f799ede7b70> but documentation defines type as 'str'
test/sanity/validate-modules/ignore.txt:1250:1: A102 Remove since "lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:1251:1: A102 Remove since "lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py" passes "E338" test

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py:0:0: E325 Argument 'networks' in argument_spec defines type as 'dict' but documentation defines type as 'str'
lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py:0:0: E325 Argument 'ovf' in argument_spec defines type as <function path_exists at 0x7f15bf991b70> but documentation defines type as 'str'
test/sanity/validate-modules/ignore.txt:1250:1: A102 Remove since "lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py" passes "E337" test
test/sanity/validate-modules/ignore.txt:1251:1: A102 Remove since "lib/ansible/modules/cloud/vmware/vmware_deploy_ovf.py" passes "E338" test

click here for bot help

@ansibot ansibot added the ci_verified label Jul 2, 2019

@Akasurde Akasurde force-pushed the Akasurde:i57849 branch 2 times, most recently from 097fb44 to e9f9fe4 Jul 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

@ansibot ansibot added support:core test and removed ci_verified labels Jul 3, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jul 3, 2019

@Akasurde Akasurde force-pushed the Akasurde:i57849 branch from e9f9fe4 to 7b42792 Jul 5, 2019

@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

@mcasasola Thanks for the review, could you please review this again with your suggestion ? Thanks in advance.

@Akasurde Akasurde removed the needs_triage label Jul 5, 2019

@Akasurde Akasurde requested review from sivel, goneri and jillr Jul 5, 2019

@ansibot ansibot added needs_revision and removed core_review labels Jul 5, 2019

@jillr

jillr approved these changes Jul 5, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jul 5, 2019

Akasurde added some commits Jul 2, 2019

VMware: Add support for storagePod
User now can be specify datastore cluster for deploying OVF

Fixes: #57849

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Added find_resource_pool_by_cluster API
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

@Tomorrow9 I brought your code here. Could you please review this ? Thanks.

@Akasurde Akasurde merged commit de66abe into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 131132 status is SUCCESS.
Details

@Akasurde Akasurde deleted the Akasurde:i57849 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.