Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_updates: Add flag to only download updates without installing them #58631

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@Ruben-Bosch
Copy link

commented Jul 2, 2019

SUMMARY

Download win_updates only.
For some use cases (low bandwidth, etc), it can be desirable to create a play which only (searches and) downloads the Windows updates. Where a later play only installs them. This saves time for our precious and relatively small maintenance windows.

Like the 'state: searched' feature, this is mainly a premature exit, since the module currently searches, downloads, installs and reboots.
Caveat: changed is True whenever there are updates available, which are at this point already downloaded. Running the module twice, will return changed=True, even when no new updates have physically been downloaded.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

modules/win_updates

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/windows/win_updates.py:190:1: W293 blank line contains whitespace
lib/ansible/modules/windows/win_updates.py:193:15: W291 trailing whitespace

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jul 2, 2019

@samdoran samdoran added the ci_verified label Jul 2, 2019

@ansibot ansibot removed the needs_triage label Jul 2, 2019

RubenBosch added some commits Jul 3, 2019

@Ruben-Bosch Ruben-Bosch marked this pull request as ready for review Jul 3, 2019

@ansibot ansibot added needs_revision and removed core_review labels Jul 3, 2019

@Ruben-Bosch Ruben-Bosch closed this Jul 3, 2019

@Ruben-Bosch Ruben-Bosch reopened this Jul 3, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jul 3, 2019

@ansibot ansibot added the stale_ci label Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.