Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding fixes required for group1 tests to pass without LC_ALL #58638

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from

Conversation

@sivel
Copy link
Member

@sivel sivel commented Jul 2, 2019

SUMMARY

Encoding fixes required for group1 tests to pass without LC_ALL

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

many

ADDITIONAL INFORMATION

@sivel sivel requested review from abadger, mattclay and samdoran Jul 2, 2019
@sivel
Copy link
Member Author

@sivel sivel commented Jul 2, 2019

I'll add LC_ALL back after tests run.

Loading

@ansibot
Copy link
Contributor

@ansibot ansibot commented Jul 2, 2019

Loading

@sivel
Copy link
Member Author

@sivel sivel commented Jul 2, 2019

I may have requested reviews too early. There is much more not functional that I am still working on.

Loading

@sivel sivel changed the title Encoding fixes required for group1 tests to pass without LC_ALL [WIP] Encoding fixes required for group1 tests to pass without LC_ALL Jul 2, 2019
@ansibot ansibot added the WIP label Jul 2, 2019
@sivel sivel closed this Jul 2, 2019
@sivel sivel reopened this Jul 3, 2019
@sivel sivel force-pushed the group1-no-lc-all branch from e091a63 to 6cb80fd Jul 3, 2019
@sivel sivel changed the title [WIP] Encoding fixes required for group1 tests to pass without LC_ALL Encoding fixes required for group1 tests to pass without LC_ALL Jul 3, 2019
@sivel
Copy link
Member Author

@sivel sivel commented Jul 3, 2019

Ok, I believe I've gotten posix/group1 taken care of. I've re-opened this PR now.

I did address some of the network issues too. win_copy is failing, but I did not look at it. It can be taken care of later.

Loading

@@ -506,7 +506,6 @@ def raw_command(cmd, capture=False, env=None, data=None, cwd=None, explain=False
def common_environment():
"""Common environment used for executing all programs."""
env = dict(
LC_ALL='en_US.UTF-8',
Copy link
Member Author

@sivel sivel Jul 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be reverted before merging.

Loading

lib/ansible/errors/__init__.py Outdated Show resolved Hide resolved
Loading
lib/ansible/modules/files/find.py Outdated Show resolved Hide resolved
Loading
lib/ansible/modules/files/find.py Outdated Show resolved Hide resolved
Loading
lib/ansible/modules/files/find.py Outdated Show resolved Hide resolved
Loading
lib/ansible/modules/files/find.py Outdated Show resolved Hide resolved
Loading
@ansibot ansibot removed the stale_ci label Oct 2, 2019
nitzmahone added a commit to nitzmahone/ansible that referenced this issue Oct 9, 2019
ci_complete
* this commit should be merged in a separate PR and removed
nitzmahone added a commit to nitzmahone/ansible that referenced this issue Oct 9, 2019
* fixes ansible#63310
* subset of fixes from ansible#58638
* added warning on error
nitzmahone added a commit that referenced this issue Oct 10, 2019
* fixes #63310
* subset of fixes from #58638
* added warning on error
nitzmahone added a commit to nitzmahone/ansible that referenced this issue Oct 10, 2019
* fixes ansible#63310
* subset of fixes from ansible#58638
* added warning on error

(cherry picked from commit 77de663)
abadger added a commit that referenced this issue Oct 10, 2019
)

* config encode errors should not be fatal (#63311)

* fixes #63310
* subset of fixes from #58638
* added warning on error

(cherry picked from commit 77de663)

* bring back text-ification from #63349
emschu pushed a commit to emschu/ansible that referenced this issue Oct 16, 2019
* fixes ansible#63310
* subset of fixes from ansible#58638
* added warning on error
anshulbehl added a commit to anshulbehl/ansible that referenced this issue Dec 10, 2019
* fixes ansible#63310
* subset of fixes from ansible#58638
* added warning on error
@sivel sivel marked this pull request as draft Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment