Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display str as type default for string #58646

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@bcoca
Copy link
Member

commented Jul 2, 2019

simplify checks for type on modules, only care if they do not match
fixes #58645

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

docs/tests

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Show resolved Hide resolved test/sanity/validate-modules/main.py Outdated
Show resolved Hide resolved test/sanity/validate-modules/main.py Outdated

@ansibot ansibot removed the needs_triage label Jul 3, 2019

@bcoca bcoca force-pushed the bcoca:use_the_defaults branch from 83b3179 to 6507c3c Jul 3, 2019

@ansibot ansibot removed the needs_rebase label Jul 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

test/sanity/validate-modules/main.py:1255:13: E303 too many blank lines (2)

click here for bot help

@ansibot ansibot added the ci_verified label Jul 3, 2019

@ansibot ansibot removed the ci_verified label Jul 9, 2019

@bcoca bcoca force-pushed the bcoca:use_the_defaults branch from 09b18ca to bec1c28 Jul 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

test/sanity/validate-modules/ignore.txt:806:1: A102 Remove since "lib/ansible/modules/clustering/consul_session.py" passes "E322" test

click here for bot help

@ansibot ansibot added the ci_verified label Jul 9, 2019

@bcoca bcoca force-pushed the bcoca:use_the_defaults branch from 59f9b30 to 76e0a92 Jul 10, 2019

@ansibot ansibot removed the ci_verified label Jul 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

test/sanity/validate-modules/ignore.txt:806:1: A102 Remove since "lib/ansible/modules/clustering/consul_session.py" passes "E322" test
test/sanity/validate-modules/ignore.txt:2170:1: A102 Remove since "lib/ansible/modules/web_infrastructure/jboss.py" passes "E325" test

click here for bot help

@ansibot ansibot added the ci_verified label Jul 10, 2019

bcoca and others added some commits Jul 2, 2019

display str as type default for string
  simplify checks for type on modules, only care if they do not match
Update test/sanity/validate-modules/main.py
Co-Authored-By: Felix Fontein <felix@fontein.de>

bcoca added some commits Jul 9, 2019

ignore new test positives
 also remove dupes and sort file

@bcoca bcoca force-pushed the bcoca:use_the_defaults branch from 76e0a92 to c8100f4 Jul 11, 2019

@ansibot ansibot added needs_rebase and removed ci_verified labels Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/web_infrastructure/jenkins_plugin.py:0:0: E325 Argument 'mode' in argument_spec defines type as 'raw' but documentation defines type as 'str'
lib/ansible/modules/web_infrastructure/jenkins_plugin.py:0:0: E325 Argument 'params' in argument_spec defines type as 'dict' but documentation defines type as 'str'
lib/ansible/modules/web_infrastructure/jenkins_plugin.py:0:0: E325 Argument 'timeout' in argument_spec defines type as 'int' but documentation defines type as 'str'
lib/ansible/modules/web_infrastructure/jenkins_plugin.py:0:0: E325 Argument 'updates_expiration' in argument_spec defines type as 'int' but documentation defines type as 'str'
test/sanity/validate-modules/ignore.txt:2169:1: A102 Remove since "lib/ansible/modules/web_infrastructure/jboss.py" passes "E325" test

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.