Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Add an initial config for the lockdown bot #58674

Open
wants to merge 1 commit into
base: devel
from

Conversation

@webknjaz
Copy link
Member

commented Jul 3, 2019

Ref: https://github.com/apps/lock

SUMMARY

Prepare a config for the lock GitHub App.

ISSUE TYPE
  • Automation Improvement Pull Request
COMPONENT NAME

bot

ADDITIONAL INFORMATION

N/A

@@ -0,0 +1,29 @@
# Number of days of inactivity before a closed issue or pull request is locked

This comment has been minimized.

Copy link
@mkrizek

mkrizek Jul 3, 2019

Contributor

Doesn't this mean that if people comment/spam on closed issues then the issue remains unlocked? I thought we wanted Number of days since closure.

This comment has been minimized.

Copy link
@webknjaz

webknjaz Jul 3, 2019

Author Member

Probably. But it's better than nothing.

This comment has been minimized.

Copy link
@mattclay

mattclay Jul 3, 2019

Member

The current implementation does use number of days since last updated:

https://github.com/dessant/lock-threads/blob/8b1ae9c84a4219662ad2dd4efec00b0888b23cf6/src/lock.js#L69

Using last closed for the query instead should be possible with modifications to the bot:

https://help.github.com/en/articles/searching-issues-and-pull-requests#search-by-when-an-issue-or-pull-request-was-closed

To keep existing auto-close behavior we should see if we can get an upstream change to the bot to support filtering based on closed date.

This comment has been minimized.

Copy link
@webknjaz

webknjaz Jul 4, 2019

Author Member

I think it should be possible.

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.