Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.8] Improve dnf test formatting and fix RHEL 8 module name (#58648) #58676

Merged
merged 1 commit into from Jul 16, 2019

Conversation

Projects
None yet
3 participants
@samdoran
Copy link
Member

commented Jul 3, 2019

SUMMARY

Backport of #58648 for Ansible 2.8

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

`test/integration/targets/dnf/

[stable-2.8] Improve dnf test formatting and fix RHEL 8 module name (#…
…58648)

- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
(cherry picked from commit 16d6fcf)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot

This comment has been minimized.

@ansibot ansibot added the stale_ci label Jul 11, 2019

@abadger abadger merged commit 6e0f2a3 into ansible:stable-2.8 Jul 16, 2019

1 check passed

Shippable Run 130703 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Merged for the 2.8.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.