Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.7] Improve dnf test formatting and fix RHEL 8 module name (#58648) #58677

Open
wants to merge 1 commit into
base: stable-2.7
from

Conversation

Projects
None yet
2 participants
@samdoran
Copy link
Member

commented Jul 3, 2019

SUMMARY

Backport of #58648 for Ansible 2.7

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/dnf/

@ansibot

This comment has been minimized.

[stable-2.7] Improve dnf test formatting and fix RHEL 8 module name (#…
…58648)

- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA.
(cherry picked from commit 16d6fcf)

Co-authored-by: Sam Doran <sdoran@redhat.com>

@samdoran samdoran force-pushed the samdoran:backport-16d6fcf-stable-2.7 branch from b45126d to 661899a Jul 3, 2019

@ansibot ansibot added the stale_ci label Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.