Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.6] Improve dnf test formatting and fix RHEL 8 module name (#58648) #58678

Merged
merged 1 commit into from Jul 17, 2019

Conversation

Projects
None yet
3 participants
@samdoran
Copy link
Member

commented Jul 3, 2019

SUMMARY

Backport of #58648 for Ansible 2.6

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/integration/targets/dnf/

@ansibot

This comment has been minimized.

[stable-2.6] Improve dnf test formatting and fix RHEL 8 module name (#…
…58648)

- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
(cherry picked from commit 16d6fcf)

@samdoran samdoran force-pushed the samdoran:backport-16d6fcf-stable-2.6 branch from 5e40cc7 to 409a98b Jul 3, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jul 3, 2019

@ansibot ansibot added the stale_ci label Jul 11, 2019

@abadger abadger merged commit d614abe into ansible:stable-2.6 Jul 17, 2019

1 check passed

Shippable Run 130733 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

merged for a theoretical 2.6.19 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.