Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding module for windows to linux copy data and vice-versa. #58681

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
4 participants
@connect2aameer
Copy link

commented Jul 3, 2019

SUMMARY

This module can be used to copy data form windows to linux & vice-versa

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

win_linux_copy

ADDITIONAL INFORMATION

This module will be helpful to copy files/folders from windows to linux or vice-versa.


@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:3:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:0:0: use "\n" for line endings instead of "\r\n"
lib/ansible/modules/windows/win_linux_copy.py:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/windows/win_linux_copy.py:21:1: W293 blank line contains whitespace
lib/ansible/modules/windows/win_linux_copy.py:46:14: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:52:1: W293 blank line contains whitespace

The test ansible-test sanity --test pslint [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:24:17: PSAvoidTrailingWhitespace Line has trailing whitespace
lib/ansible/modules/windows/win_linux_copy.ps1:30:82: PSAvoidTrailingWhitespace Line has trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.py:0:0: E307 version_added should be '2.9'. Currently '2.4'
lib/ansible/modules/windows/win_linux_copy.py:99:64: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:99:64: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:3:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:0:0: use "\n" for line endings instead of "\r\n"
lib/ansible/modules/windows/win_linux_copy.py:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/windows/win_linux_copy.py:21:1: W293 blank line contains whitespace
lib/ansible/modules/windows/win_linux_copy.py:46:14: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:52:1: W293 blank line contains whitespace

The test ansible-test sanity --test pslint [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:24:17: PSAvoidTrailingWhitespace Line has trailing whitespace
lib/ansible/modules/windows/win_linux_copy.ps1:30:82: PSAvoidTrailingWhitespace Line has trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.py:0:0: E307 version_added should be '2.9'. Currently '2.4'
lib/ansible/modules/windows/win_linux_copy.py:96:64: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:96:64: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:3:1: SyntaxError:

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:0:0: use "\n" for line endings instead of "\r\n"
lib/ansible/modules/windows/win_linux_copy.py:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 3 errors:

lib/ansible/modules/windows/win_linux_copy.py:20:66: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:45:14: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:50:25: W291 trailing whitespace

The test ansible-test sanity --test pslint [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:24:17: PSAvoidTrailingWhitespace Line has trailing whitespace
lib/ansible/modules/windows/win_linux_copy.ps1:30:82: PSAvoidTrailingWhitespace Line has trailing whitespace

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.py:0:0: E307 version_added should be '2.9'. Currently '2.4'
lib/ansible/modules/windows/win_linux_copy.py:94:64: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:94:64: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@nitzmahone

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Given prior experience with similar things (cough synchronize cough), I'm going to say -1 to merging this into the core distribution. So many things to go wrong, and can't be fully tested in CI. It's also not idempotent, so there's not really any significant benefit to this over just using win_shell to call pscp...

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:0:0: has a documentation error formatting or is missing documentation.

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:45: SyntaxError: from module_utils.basic import AnsibleModule

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ImportError: No module named module_utils.basic

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ImportError: No module named module_utils.basic

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ImportError: No module named 'module_utils'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ModuleNotFoundError: No module named 'module_utils'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ModuleNotFoundError: No module named 'module_utils'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/windows/win_linux_copy.py:1:0: ModuleNotFoundError: No module named 'module_utils'

The test ansible-test sanity --test line-endings [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:0:0: use "\n" for line endings instead of "\r\n"
lib/ansible/modules/windows/win_linux_copy.py:0:0: use "\n" for line endings instead of "\r\n"

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/windows/win_linux_copy.py:2:1: E265 block comment should start with '# '
lib/ansible/modules/windows/win_linux_copy.py:21:66: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:46:14: W291 trailing whitespace
lib/ansible/modules/windows/win_linux_copy.py:51:25: W291 trailing whitespace

The test ansible-test sanity --test pslint [explain] failed with 2 errors:

lib/ansible/modules/windows/win_linux_copy.ps1:24:17: PSAvoidTrailingWhitespace Line has trailing whitespace
lib/ansible/modules/windows/win_linux_copy.ps1:30:82: PSAvoidTrailingWhitespace Line has trailing whitespace

click here for bot help

@ansibot ansibot removed the needs_triage label Jul 3, 2019

@ansibot ansibot added the stale_ci label Jul 11, 2019

@jborean93

This comment has been minimized.

Copy link
Contributor

commented Jul 21, 2019

I have to agree with @nitzmahone here, there is little that this module adds that can't just be done with a win_commandorwin_shell` task. Not having any idempotency and also a reliance on an external tool also are things we don't really want to see. We appreciate the work you've put into this but unfortunately it's not something we see being merged into this repository.

You are more than welcome to create a collection of your Ansible work and distribute it through Ansible Galaxy, some starting docs for this can be found at https://galaxy.ansible.com/docs/contributing/creating_collections.html.

@jborean93 jborean93 closed this Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.