Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: only create new vmdk when creating new VM not from template in vmware_guest #58711

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@Tomorrow9
Copy link
Contributor

commented Jul 4, 2019

SUMMARY

Fixes #57817

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

Fix a regression issue in 2.8 when deploying VM from template, the operation failed due to cloned VM's vmdk already exist but attempt to create a new one as new creating a fresh VM.


@ansibot

This comment has been minimized.

@kobayashi

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

LGTM

@m3300b

This comment has been minimized.

Copy link

commented Jul 8, 2019

@Tomorrow9
I think this will break the case when cloning from a template and adding a new disk, how about we change this to:
elif vm_obj is None or disk_modified:

@nagonzalez

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Sorry folks. I missed this PR when I submitted one for the similar issues:
#58737

I believe @m3300b is correct. As proposed it would break if you're adding a new disk.

@nagonzalez

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

@Tomorrow9
I think this will break the case when cloning from a template and adding a new disk, how about we change this to:
elif vm_obj is None or disk_modified:

I believe this will break as well as it will try to create a new disk when resizing disks in a template.

@Tomorrow9

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Since PR #58737 has been merged to fix this issue, I'll close this PR. Thanks.

@Tomorrow9 Tomorrow9 closed this Jul 16, 2019

@Tomorrow9 Tomorrow9 deleted the Tomorrow9:fix_pr57817 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.