Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: New Module for content library CRUD operations #58716

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@pgbidkar
Copy link
Contributor

commented Jul 4, 2019

SUMMARY

New module to create, Update & delete content library.
Content library created with datastore backing

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

VMWare content library

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:0:0: missing documentation (or could not parse documentation): invalid syntax (<unknown>, line 6)

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:6:1: SyntaxError:

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/vmware_content_library/aliases:0:0: missing alias `shippable/posix/group[1-4]` or `unsupported`

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:0:0: use "\n" for line endings instead of "\r\n"

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 4, 2019

@GBrawl @MikeKlebolt @Tomorrow9 @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @davidmhewitt @garbled1 @gyorgypeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @nafpliot-ibm @nerzhul @oboukili @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Akasurde Akasurde changed the title New Module for content library CRUD operations VMware: New Module for content library CRUD operations Jul 5, 2019

@Akasurde Akasurde removed the needs_triage label Jul 5, 2019

@Akasurde Akasurde self-assigned this Jul 5, 2019

@Akasurde Akasurde requested review from goneri and jillr Jul 5, 2019

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from 3f94ac0 to 1a47e1c Jul 5, 2019

@pgbidkar

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Thanks @Akasurde for reviews. Committed the changes. Please review

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:29: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added the ci_verified label Jul 5, 2019

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from 1a47e1c to 8598dee Jul 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:33: E127 continuation line over-indented for visual indent

click here for bot help

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from 8598dee to d6fa480 Jul 5, 2019

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from d6fa480 to bb4dffc Jul 5, 2019

@ansibot ansibot removed the ci_verified label Jul 5, 2019

@jillr
Copy link
Contributor

left a comment

Otherwise lgtm

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from bb4dffc to 7fb9e3a Jul 9, 2019

@pgbidkar
Copy link
Contributor Author

left a comment

Handled review comments.

@pgbidkar

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Hi @jillr @Akasurde , Thanks for the review comments. Handled review comments. Please review again

Thanks

@pgbidkar
Copy link
Contributor Author

left a comment

Hi @goneri, Thanks for review comments. Please let me know your inputs on my queries

Thanks

@ansible ansible deleted a comment from pgbidkar Jul 10, 2019

@goneri

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

You may find this new doc useful: https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/platforms/vmware_guidelines.rst

It explains how to run the test-suite locally.

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from 7fb9e3a to aabbf5f Jul 10, 2019

@pgbidkar
Copy link
Contributor Author

left a comment

Made changes as per review comments

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:217:69: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:220:33: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:221:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:222:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:223:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:224:45: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:282:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch from aabbf5f to 4bfb2c6 Jul 10, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:224:47: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:225:34: E124 closing bracket does not match visual indentation

click here for bot help

@pgbidkar pgbidkar force-pushed the pgbidkar:content-crud branch 2 times, most recently from b8b58a1 to a816e4b Jul 10, 2019

New Module for content library CRUD operations
* Fixing file format issue. converted file from dos2unix
* Review comments changes
* Changes as per review comments. Moved integration test files to module name folder
* Fixed precheck failures
* Fixed few more precheck failures. Visual indentation fix and testname duplication fix in integration fix

@Akasurde Akasurde force-pushed the pgbidkar:content-crud branch from a816e4b to d1025eb Jul 12, 2019

@jillr

jillr approved these changes Jul 12, 2019

@jillr jillr merged commit 7b8edbf into ansible:devel Jul 12, 2019

1 check passed

Shippable Run 131877 status is SUCCESS.
Details

anshulbehl added a commit to anshulbehl/ansible that referenced this pull request Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.