Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies #58771

Merged
merged 2 commits into from Jul 15, 2019

Conversation

Projects
None yet
4 participants
@dwyerk
Copy link
Contributor

commented Jul 5, 2019

SUMMARY

There is a bug when installing a deb with dependencies in an unauthenticated repo. Normally we can just add allow_unauthenticated to the apt stanza but in the case of a deb file, the allow_unauthenticated setting is ignored. This change passes the value down to the install function so that the setting is no longer ignored.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt

ADDITIONAL INFORMATION

Try it out like so:

- name: Add poorly configured repository
  apt_repository:
    repo: "deb http://apt_repo/missing_gpg_signed_Packages"
    state: present

- name: deb with unauthenticated dependencies
  apt:
    deb: ./mypackage.deb
    allow_unauthenticated: yes
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

@samdoran samdoran changed the title Pass allow_unauthenticated when installing a deb directly - allowing … Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies Jul 11, 2019

@bcoca bcoca added P3 and removed needs_triage labels Jul 11, 2019

@mkrizek
Copy link
Contributor

left a comment

This looks good. Would you mind adding a changelog (see https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)? I'll merge afterwards. Thanks!

@ansibot ansibot added needs_revision and removed core_review labels Jul 12, 2019

@dwyerk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

@mkrizek Sure thing. Have a look and make sure I got the changelog formatted right.

@mkrizek mkrizek merged commit ec35cbc into ansible:devel Jul 15, 2019

1 check passed

Shippable Run 131916 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.