Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport machinectl become plugin fixes (#58734) #58774

Merged
merged 3 commits into from Jul 16, 2019

Conversation

Projects
None yet
4 participants
@jos-b
Copy link
Contributor

commented Jul 5, 2019

SUMMARY

Backports the fixes from #58734 to Ansible 2.8 where the issues were introduced.

This prevents an attribute error and a ansible error due to some incorrect configuration settings, it also adds support for systemd v230 by changing the order of some parameters to machinectl.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

machinectl become plugin

jos-b added some commits Jul 5, 2019

Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)

(cherry picked from commit 4f642da)
@felixfontein

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Thanks for backporting this!

I think it's better to remove the last commit, though. For all other changelog fragments I know of, the PR number equals the one of the original PR, not the backport PR.

@jos-b

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2019

Reverted, thanks for letting me know 👍

@ansibot ansibot added the stale_ci label Jul 16, 2019

@abadger abadger merged commit 6d467a8 into ansible:stable-2.8 Jul 16, 2019

1 check passed

Shippable Run 131026 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Merged for the 2.8.3 release

@jos-b jos-b deleted the jos-b:backport/2.8/58734 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.