Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed command for next-hop-self to next-hop-self instead of activate #58789

Merged
merged 1 commit into from Jul 6, 2019

Conversation

Projects
None yet
4 participants
@jvanderaa
Copy link
Contributor

commented Jul 6, 2019

SUMMARY

Modified lib/ansible/module_utils/network/ios/providers/cli/config/bgp/neighbors.py line 166 to be neighbor %s next-hop-self instead of neighbor %s activate for proper command processing

Fixes #58788

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_bgp

ADDITIONAL INFORMATION

When testing out the ios_bgp command I found that it was not sending next-hop-self to the routers. I dug in and found where this was set and it was a copy/paste from activate that missed changing the command. Very plausible to be done.

ok: [r4] => {
    "msg": {
        "changed": true,
        "commands": [
            "no router bgp 65500",
            "router bgp 65500",
            "bgp router-id 10.0.0.4",
            "bgp log-neighbor-changes",
            "neighbor 192.0.2.5 remote-as 65510",
            "neighbor 192.0.2.5 timers 15 45 5",
            "neighbor 192.0.2.5 description R2 Uplink",
            "neighbor 198.51.100.1 remote-as 65500",
            "neighbor 198.51.100.1 timers 15 45 5",
            "neighbor 198.51.100.1 description R3 conenction",
            "network 0.0.0.0",
            "address-family ipv4",
            "redistribute eigrp 20 metric 10",
            "neighbor 198.51.100.1 activate",
            "neighbor 198.51.100.1 next-hop-self",
            "exit-address-family",
            "exit"
        ],
        "failed": false
    }
}
@ansibot

This comment has been minimized.

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 6, 2019

Build succeeded (third-party-check pipeline).

@NilashishC
Copy link
Contributor

left a comment

Thanks for fixing this!

@NilashishC NilashishC merged commit 73db7e2 into ansible:devel Jul 6, 2019

2 checks passed

Shippable Run 131047 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details

@sivel sivel removed the needs_triage label Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.