Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker_* modules: improve tag validation and requests error handling #58791

Merged
merged 6 commits into from Jul 13, 2019

Conversation

Projects
None yet
3 participants
@felixfontein
Copy link
Contributor

commented Jul 6, 2019

SUMMARY

Fixes #58770.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_image
docker_* modules

@felixfontein felixfontein changed the title [WIP] docker_* modules: improve tag validation [WIP] docker_* modules: improve tag validation and requests error handling Jul 8, 2019

@ansibot

This comment has been minimized.

@felixfontein felixfontein changed the title [WIP] docker_* modules: improve tag validation and requests error handling docker_* modules: improve tag validation and requests error handling Jul 9, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

ready_for_review

@ansibot ansibot added community_review and removed WIP labels Jul 9, 2019

@WojciechowskiPiotr

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

shipit

@felixfontein felixfontein merged commit 8d6f184 into ansible:devel Jul 13, 2019

1 check passed

Shippable Run 131204 status is SUCCESS.
Details

@felixfontein felixfontein deleted the felixfontein:docker-check-tag branch Jul 13, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2019

@WojciechowskiPiotr thanks for reviewing this!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Jul 13, 2019

docker_* modules: improve tag validation and requests error handling (a…
…nsible#58791)

* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.

(cherry picked from commit 8d6f184)

abadger added a commit that referenced this pull request Jul 17, 2019

docker_* modules: improve tag validation and requests error handling (#…
…58791)

* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.

(cherry picked from commit 8d6f184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.