Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_file: Add a parameter to append options #58794

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@bbusse
Copy link

commented Jul 6, 2019

Currently it is not possible to have duplicate keys as e.g. required
to write VLANs to systemd-networkd network files. This commit adds
a parameter append_option which defaults to 'no' and thus does not
change the module behaviour. If set to yes, no existing options are
changed but options are appended instead.

ini_file: Add a parameter to append options
Currently it is not possible to have duplicate keys as e.g. required
to write VLANs to systemd-networkd network files. This commit adds
a parameter append_option which defaults to 'no' and thus does not
change the module behaviour. If set to yes, no existing options are
changed but options are appended instead.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/files/ini_file.py:0:0: E309 version_added for new option (append_option) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2019

@bbusse

This comment has been minimized.

Copy link
Author

commented Jul 7, 2019

Checking for duplicate 'option=value' for the append_option case and doing nothing in that case probably makes sense though..

@bbusse

This comment has been minimized.

Copy link
Author

commented Jul 7, 2019

Checking for duplicate 'option=value' for the append_option case and doing nothing in that case probably makes sense though..

Not needed since we run into the default case which already handles this

@ansibot ansibot added the stale_ci label Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.