Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in unixy callback v2_runner_retry #58801

Merged
merged 1 commit into from Jul 13, 2019

Conversation

Projects
None yet
4 participants
@jpic
Copy link
Contributor

commented Jul 7, 2019

This fixes the warning:

[WARNING]: Failure using method (v2_runner_retry) in callback plugin
(<ansible.plugins.callback.unixymdv.CallbackModule object at 0x7fb4fd4eeef0>): _run_is_verbose() got
an unexpected keyword argument 'verbosity'
SUMMARY

Fixes a little exception, probably on code that needed update

ISSUE TYPE
  • Bugfix Pull Reques
COMPONENT NAME

unixy callback plugin

ADDITIONAL INFORMATION
- hosts: '*'
  tasks:
  - pause:
      prompt:
    until: false
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2019

@@ -236,6 +236,6 @@ def v2_playbook_on_start(self, playbook):

def v2_runner_retry(self, result):
msg = " Retrying... (%d of %d)" % (result._result['attempts'], result._result['retries'])
if self._run_is_verbose(result, verbosity=2):
if self._display.verbosity > 1:

This comment has been minimized.

Copy link
@Akasurde

Akasurde Jul 8, 2019

Member
Suggested change
if self._display.verbosity > 1:
if self._run_is_verbose(result):

This comment has been minimized.

Copy link
@akatch

akatch Jul 10, 2019

Contributor

Agree with this suggestion, thank you for submitting the patch @jpic

This comment has been minimized.

Copy link
@jpic

jpic Jul 11, 2019

Author Contributor

Done !
Note that line 227 there is self._display.verbosity > 3
https://github.com/ansible/ansible/pull/58801/files#diff-bfc0fb65ff63d5ae485526877e282f97R227
Have a great day

@ansibot ansibot removed the needs_triage label Jul 8, 2019

Fix exception in unixy callback v2_runner_retry
This fixes the warning:
[WARNING]: Failure using method (v2_runner_retry) in callback plugin
(<ansible.plugins.callback.unixymdv.CallbackModule object at 0x7fb4fd4eeef0>): _run_is_verbose() got
an unexpected keyword argument 'verbosity'

@jpic jpic force-pushed the jpic:patch-3 branch from 736dc13 to 41c4c1d Jul 11, 2019

@Akasurde
Copy link
Member

left a comment

shipit

@akatch

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@ansibot ansibot added shipit and removed community_review labels Jul 12, 2019

@Akasurde Akasurde merged commit 945e35a into ansible:devel Jul 13, 2019

1 check passed

Shippable Run 131622 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.