Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Reuse get_collector_names method for network facts gathering #58817

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@trishnaguha
Copy link
Member

commented Jul 8, 2019

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

Reuse get_collector_names method for network facts gathering

COMPONENT NAME

module_utils/network/common/facts/facts.py

@trishnaguha trishnaguha requested a review from ganeshrn Jul 8, 2019

@ansibot

This comment has been minimized.

@trishnaguha trishnaguha force-pushed the trishnaguha:reuse_get_collector_names_method branch from d169ac2 to e4cacd4 Jul 8, 2019

@ansible ansible deleted a comment from ansibot Jul 8, 2019

restorun_subsets = self.gen_runable(resource_facts_type, frozenset(net_res_choices))
valid_subsets = net_res_choices
gather_subset = resource_facts_type
restorun_subsets = get_collector_names(valid_subsets, gather_subset=gather_subset)

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 8, 2019

Member

net_res_choices and resource_facts_type can be passed directly get_collector_names instead of seperately crearting those two varaible or instead net_res_choices can be renamed as valid_subsets and resource_facts_type to gather_subset

runable_subsets.add('default')
valid_subsets = frozenset(fact_legacy_obj_map.keys())
minimal_gather_subset = frozenset(['default'])
gather_subset = legacy_facts_type

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 8, 2019

Member

Same as above

@ansibot ansibot removed the needs_triage label Jul 8, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:reuse_get_collector_names_method branch from e4cacd4 to 2b1448e Jul 8, 2019

@ganeshrn
Copy link
Member

left a comment

Thank you!

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 8, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

Reuse get_collector_names method for network facts gathering
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:reuse_get_collector_names_method branch from 2b1448e to 605f26f Jul 9, 2019

@ansibot ansibot added the support:core label Jul 9, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 9, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@@ -93,7 +48,8 @@ def get_network_resources_facts(self, net_res_choices, facts_resource_obj_map, r
if not resource_facts_type:
resource_facts_type = self._gather_network_resources

restorun_subsets = self.gen_runable(resource_facts_type, frozenset(net_res_choices))
restorun_subsets = get_collector_names(valid_subsets=net_res_choices,

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 9, 2019

Member

This should be frozenset(net_res_choices)

@trishnaguha trishnaguha changed the title Reuse get_collector_names method for network facts gathering [WIP]Reuse get_collector_names method for network facts gathering Jul 9, 2019

@ansibot ansibot added the WIP label Jul 9, 2019

@ansibot ansibot added the stale_ci label Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.