Skip to content

[WIP]Reuse get_collector_names method for network facts gathering #58817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trishnaguha wants to merge 1 commit into from
Closed

[WIP]Reuse get_collector_names method for network facts gathering #58817

trishnaguha wants to merge 1 commit into from

Conversation

@trishnaguha
Copy link
Member

@trishnaguha trishnaguha commented Jul 8, 2019 •
edited
Loading

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY

Reuse get_collector_names method for network facts gathering

COMPONENT NAME

module_utils/network/common/facts/facts.py

@trishnaguha trishnaguha requested a review from ganeshrn July 8, 2019 08:40
@ansibot
Copy link
Contributor

ansibot commented Jul 8, 2019

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:network This issue/PR relates to code supported by the Ansible Network Team. labels Jul 8, 2019
@trishnaguha trishnaguha force-pushed the reuse_get_collector_names_method branch from d169ac2 to e4cacd4 Compare July 8, 2019 09:01
@ansible ansible deleted a comment from ansibot Jul 8, 2019
ganeshrn
ganeshrn reviewed Jul 8, 2019
View reviewed changes
lib/ansible/module_utils/network/common/facts/facts.py Outdated
Copy link
Member

@ganeshrn ganeshrn Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

net_res_choices and resource_facts_type can be passed directly get_collector_names instead of seperately crearting those two varaible or instead net_res_choices can be renamed as valid_subsets and resource_facts_type to gather_subset

ganeshrn
ganeshrn reviewed Jul 8, 2019
View reviewed changes
lib/ansible/module_utils/network/common/facts/facts.py Outdated
Copy link
Member

@ganeshrn ganeshrn Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 8, 2019
@trishnaguha trishnaguha force-pushed the reuse_get_collector_names_method branch from e4cacd4 to 2b1448e Compare July 8, 2019 09:33
ganeshrn
ganeshrn approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ansible-zuul
Copy link

ansible-zuul bot commented Jul 8, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@trishnaguha
Reuse get_collector_names method for network facts gathering
605f26f 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
@trishnaguha trishnaguha force-pushed the reuse_get_collector_names_method branch from 2b1448e to 605f26f Compare July 9, 2019 07:25
@ansibot ansibot added the support:core This issue/PR relates to code supported by the Ansible Engineering Team. label Jul 9, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented Jul 9, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

ganeshrn
ganeshrn reviewed Jul 9, 2019
View reviewed changes
lib/ansible/module_utils/network/common/facts/facts.py
resource_facts_type = self._gather_network_resources

restorun_subsets = self.gen_runable(resource_facts_type, frozenset(net_res_choices))
restorun_subsets = get_collector_names(valid_subsets=net_res_choices,
Copy link
Member

@ganeshrn ganeshrn Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be frozenset(net_res_choices)

@trishnaguha trishnaguha changed the title Reuse get_collector_names method for network facts gathering [WIP]Reuse get_collector_names method for network facts gathering Jul 9, 2019
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jul 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 17, 2019
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Sep 9, 2019
@ansibot ansibot added collection Related to Ansible Collections work collection:ansible.netcommon labels Apr 29, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 6, 2020
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. and removed networking Network category labels Jul 12, 2023
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Oct 24, 2023
@Akasurde
Copy link
Member

Akasurde commented Dec 16, 2024

Code is migrated to https://github.com/ansible-collections/ansible.netcommon/blob/main/plugins/module_utils/network/common/facts/facts.py.

Closing for now. Thanks.

@Akasurde Akasurde closed this Dec 16, 2024
@ansible ansible locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ganeshrn ganeshrn ganeshrn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects_2.9 This issue/PR affects Ansible v2.9 collection:ansible.netcommon collection Related to Ansible Collections work needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. stale_review Updates were made after the last review and the last review is more than 7 days old. support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:network This issue/PR relates to code supported by the Ansible Network Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trishnaguha @ansibot @Akasurde @ganeshrn