Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if users are None/empty, dont assume sameness #58875

Merged
merged 1 commit into from Jul 17, 2019

Conversation

Projects
None yet
4 participants
@bcoca
Copy link
Member

commented Jul 9, 2019

prevents None == None cases in which 'defaults' for remote and become differ

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

actions

@sivel

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

We should probably extend the tests in test_action_base_sudo_only_if_user_differs at test/units/plugins/action/test_action.py to test this logic.

@bcoca

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

and add clog, was just seeing if all current tests passed

@samdoran
Copy link
Member

left a comment

We definitely need test cases for this. It's pretty hard to follow this logic even when it is broken out into a separate method.

Show resolved Hide resolved lib/ansible/plugins/action/__init__.py

@ansibot ansibot added needs_revision and removed core_review labels Jul 9, 2019

@bcoca bcoca removed the needs_triage label Jul 11, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jul 17, 2019

@bcoca bcoca merged commit 4ef2545 into ansible:devel Jul 17, 2019

1 check passed

Shippable Run 131340 status is SUCCESS.
Details

@bcoca bcoca deleted the bcoca:become_none branch Jul 17, 2019

bcoca added a commit to bcoca/ansible that referenced this pull request Jul 17, 2019

if users are None/empty, dont assume sameness (ansible#58875)
(cherry picked from commit 4ef2545eb5d661566e06629015967c2d1b8924e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.