Fix nxos_ospf_vrf python3 compatibility issue #58885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure division results in an integer since NXOS can't handle a floating point value for the auto-cost reference-bandwidth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure division results in an integer since NXOS can't
handle a floating point value for the auto-cost reference-bandwidth
SUMMARY
In python 3, the / operator yields a float even when both operands are ints. When python3 is used as the interpreter, the module will fail when trying to set the auto-cost reference bandwidth:
fatal: [switchname]: FAILED! => {"changed": false, "msg": "auto-cost reference-bandwidth 100.0 Gbps\r\r\n ^\r\n% Invalid number at '^' marker.\r\n\switchname(config-router)# "}
This patch implements the python3 '//' operator for integer floor division
ISSUE TYPE
COMPONENT NAME
nxos
ADDITIONAL INFORMATION