Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.8] Update default test container to use Python 3.8.0b2 (#58877) #58891

Open
wants to merge 1 commit into
base: stable-2.8
from

Conversation

Projects
None yet
4 participants
@samdoran
Copy link
Member

commented Jul 9, 2019

SUMMARY

Backport of #58877 for Ansible 2.8

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/runner/completion/docker.txt

[stable-2.8] Update default test container to use Python 3.8.0b2 (#58877
).

(cherry picked from commit 5ccd674)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

The test ansible-test sanity --test pslint [explain] failed with 10 errors:

lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1:51:9: PSAvoidUsingPositionalParameters Cmdlet 'Set-Attr' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1:82:5: PSAvoidUsingPositionalParameters Cmdlet 'Set-Attr' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1:83:5: PSAvoidUsingPositionalParameters Cmdlet 'Set-Attr' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/module_utils/powershell/Ansible.ModuleUtils.Legacy.psm1:86:9: PSAvoidUsingPositionalParameters Cmdlet 'Set-Attr' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_lineinfile.ps1:194:12: PSAvoidUsingPositionalParameters Cmdlet 'WriteLines' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_lineinfile.ps1:276:12: PSAvoidUsingPositionalParameters Cmdlet 'WriteLines' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_lineinfile.ps1:398:2: PSAvoidUsingPositionalParameters Cmdlet 'Present' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_lineinfile.ps1:407:2: PSAvoidUsingPositionalParameters Cmdlet 'Absent' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_xml.ps1:26:17: PSAvoidUsingPositionalParameters Cmdlet 'Copy-Xml' has positional parameter. Please use named parameters instead of positional parameters when calling a command.
lib/ansible/modules/windows/win_xml.ps1:129:5: PSAvoidUsingPositionalParameters Cmdlet 'Copy-Xml' has positional parameter. Please use named parameters instead of positional parameters when calling a command.

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jul 9, 2019

@samdoran

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

I believe we need to backport #55862 in order to address these test failures.

@mattclay

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@abadger What do you think about backporting #55862?

If we don't want to do that we can simply add the necessary ignores to this PR instead.

@abadger

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

I've asked jborean to confirm there's no features in #55862 and that it is okay with him to backport. I'm okay with it being backported if he signs off on those two things.

@abadger

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

Update: @jborean93 says he'd rather that does not get backported. So we should add the necessary ignores to this PR instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.